Changeset 528:248680ae10e9

Timestamp:

04/23/08 15:51:32 (2 years ago)

Author:

Mateusz Loskot <mateusz@…>

Branch:

default

Convert:

svn:1766ff46-f334-0410-ab20-d63176f87757/trunk@593

Message:

Updated LASHeader test to check boundary cases of string data members.

File:

• test/unit/lasheader_test.cpp (modified) (3 diffs)

test/unit/lasheader_test.cpp

@@ -193 +193 @@
         std::string sysid1("Short Sys Id"); // 12 bytes
         std::string::size_type const len1 = sysid1.size();
-        std::string sysid2("Long System Identifier - and some garbage"); // 41 bytes
+        std::string sysid2("Long System Identifier - XXX YYY"); // 32 bytes
         std::string::size_type const len2 = sysid2.size();
 
@@ -203 +203 @@
         ensure_equals(h.GetSystemId(true).size(), 32);
 
-        // TODO: Should we allow passing longer identifier than 32 bytes
-        //       and truncate it implicitly, so the following test will pass?
-        //h.SetSystemId(sysid2);
-        //ensure_equals(h.GetSystemId(), sysid2.substr(0, 32));
-        //ensure_equals(h.GetSystemId().size(), len2);
-        //ensure_equals(h.GetSystemId(true).size(), 32);
+        h.SetSystemId(sysid2);
+        ensure_equals(h.GetSystemId(), sysid2);
+        ensure_equals(h.GetSystemId().size(), len2);
+        ensure_equals(h.GetSystemId(true).size(), 32);
     }
 
@@ -218 +216 @@
         using liblas::LASHeader;
 
-        std::string softd1("Short Soft Id"); // 13 bytes
-        std::string::size_type const len1 = softd1.size();
+        std::string softid1("Short Soft Id"); // 13 bytes
+        std::string::size_type const len1 = softid1.size();
+        std::string softid2("Long Software Identifier - XX YY"); // 32 bytes
+        std::string::size_type const len2 = softid2.size();
 
         LASHeader h;
-        h.SetSoftwareId(softd1);
-        ensure_equals(h.GetSoftwareId(), softd1);
+        h.SetSoftwareId(softid1);
+        ensure_equals(h.GetSoftwareId(), softid1);
         ensure_equals(h.GetSoftwareId().size(), len1);
         ensure_equals(h.GetSoftwareId(true).size(), 32);
 
-        // TODO: What about passing longer value and implicit truncation?
+        h.SetSoftwareId(softid2);
+        ensure_equals(h.GetSoftwareId(), softid2);
+        ensure_equals(h.GetSoftwareId().size(), len2);
+        ensure_equals(h.GetSoftwareId(true).size(), 32);
     }