Changeset 1610:d4dc6b81246b

Timestamp:

03/02/10 15:48:30 (5 months ago)

Author:

Mateusz Loskot <mateusz@…>

Branch:

default

Message:

In las2oci.cpp, replaced post-increment with pre-increment for iterators, TODO comment where possible memory leak may occur (cannot test myself), missing include <vector>.

File:

• apps/las2oci.cpp (modified) (5 diffs)

apps/las2oci.cpp

@@ -19 +19 @@
 #include <exception>
 #include <algorithm>
+#include <vector>
 #include <cctype>
 #include <cmath>
@@ -392 +393 @@
     std::vector<liblas::uint8_t> point_data;
     
-    for (i=ids.begin(); i!=ids.end(); i++) 
+    for (i=ids.begin(); i!=ids.end(); ++i) 
     {
         SpatialIndex::id_type id = *i;
@@ -405 +406 @@
             if (!gotdata) { throw std::runtime_error("Unable to fetch Point Data"); exit(1);}
             std::vector<liblas::uint8_t>::const_iterator d;
-            for (d = point_data.begin(); d!=point_data.end(); d++) {
+            for (d = point_data.begin(); d!=point_data.end(); ++d) {
                 data.push_back(*d);
             }
@@ -534 +535 @@
     b->num_points[index] = (long)ids.size();
     
+    // TODO: This probably is a memory leak if the gotdata == false --mloskot
     std::vector<liblas::uint8_t>* blob = new std::vector<liblas::uint8_t>;
     
@@ -764 +766 @@
                 )
 {
-
-    
     std::list<LASQueryResult>::const_iterator i;
-
-
 
     long commit_interval = 1000;